[PATCH] D141495: [clangd] Suppress clang-tidy warnings for code spelled in system macros

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 11 09:00:52 PST 2023


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:545
           }
+          // Match behavior for clang-tidy --system-headers=0 (the default).
+          if (Info.hasSourceManager() &&
----------------
nridge wrote:
> Why not check `CTContext->getOptions().SystemHeaders`, since we have ready access to it?
Ah, my mistake, I thought this was some global flag rather than part of tidy options (not sure why I thought that), will fix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141495/new/

https://reviews.llvm.org/D141495



More information about the cfe-commits mailing list