[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:12428
   F->addFnAttr(llvm::Attribute::NoUnwind);
+  F->addFnAttr(llvm::Attribute::Convergent);
 
----------------
yaxunl wrote:
> How about using CGF.CGM.addDefaultFunctionDefinitionAttributes? same as below
That's what the fixme is for. I wanted to do this as 2 steps because first it explicitly shows the convergent problem more clearly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141449/new/

https://reviews.llvm.org/D141449