[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me. See comments though



================
Comment at: clang/include/clang/Driver/Driver.h:488
+                  Action::OffloadKind Kind, const ToolChain *TC,
+                  bool Query = false) const;
 
----------------
I wouldn't call it query but it's not too bad either. I'd call it "SuppressErrors".


================
Comment at: clang/lib/Driver/Driver.cpp:894
+        return;
+      }
+
----------------
Does this necessarily mean we failed with `=native`, if so it's ok. Just didn't follow the logic all the way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141105/new/

https://reviews.llvm.org/D141105