[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 10 21:34:22 PST 2023


MaskRay added inline comments.


================
Comment at: libunwind/src/AddressSpace.hpp:249
   const uint8_t *pend = (uint8_t *)end;
-  int64_t result = 0;
+  uint64_t result = 0;
   int bit = 0;
----------------
Thanks. LGTM for this file. You can just fix libunwind in a separate commit so that this patch focuses on its main work. You can then remove `#libunwind` from the reviewer list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139114/new/

https://reviews.llvm.org/D139114



More information about the cfe-commits mailing list