[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

In D141324#4039629 <https://reviews.llvm.org/D141324#4039629>, @erichkeane wrote:

> I'm disturbed that the string-literal diagnostic you changed never shows up in the tests.  I suspect this attribute needs significantly better test coverage.

Please elaborate. All the diagnostics have appropriate coverage already.



================
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:58
           "for optional message in 'availability' attribute|"
-          "for %select{language|source container}1 name in "
+          "for %select{language name|source container name|USR}1 in "
           "'external_source_symbol' attribute}0">;
----------------
erichkeane wrote:
> I don't think adding 'name' to these makes them particularly more readable?  At least from what I can see reading it here.  
I did not add 'name' here, I moved it from the right hand side as I added a new clause that didn't use name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141324/new/

https://reviews.llvm.org/D141324