[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

Felipe de Azevedo Piovezan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 10 06:36:31 PST 2023


fdeazeve added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.h:494
+                           CGBuilderTy &Builder,
+                           const bool UsePointerValue = false);
 
----------------
FWIW I used a `const` bool here to match the style already present in this class


================
Comment at: clang/lib/CodeGen/CGDecl.cpp:2482
+                                   CGM.getCodeGenOpts().hasReducedDebugInfo() &&
+                                   !CurFuncIsThunk && !NoDebugInfo;
+
----------------
this is hoisted from below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141381/new/

https://reviews.llvm.org/D141381



More information about the cfe-commits mailing list