[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 10 05:57:06 PST 2023


asb created this revision.
asb added reviewers: sunho, lhames.
Herald added subscribers: wingo, sunshaoce, pmatos, VincentWu, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, kristof.beyls, arichardson.
Herald added a project: All.
asb requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD.
Herald added a project: clang.

I'm not familiar with this infrastructure so haven't dug into why it's failing, but it is failing for me on RISC-V. As Arm targets are also XFAILed it doesn't seem like an unreasonable "fix" to XFAIL for RISC-V too - but if it looks like an easy fix might be possible from someone who's been working in the area, I'd obviously welcome that as an alternative!

For reference, the output of this test is currently:

  clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> clang-repl> Running f()
  terminate called after throwing an instance of 'char const*'
  Aborted (core dumped)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141380

Files:
  clang/test/Interpreter/simple-exception.cpp


Index: clang/test/Interpreter/simple-exception.cpp
===================================================================
--- clang/test/Interpreter/simple-exception.cpp
+++ clang/test/Interpreter/simple-exception.cpp
@@ -1,7 +1,7 @@
 // clang-format off
 // UNSUPPORTED: system-aix
-// XFAIL for arm and arm64, or running on Windows.
-// XFAIL: target=arm{{.*}}, system-windows
+// XFAIL for arm, arm64, riscv, or running on Windows.
+// XFAIL: target={{(arm|riscv).*}}, system-windows
 // RUN: cat %s | clang-repl | FileCheck %s
 extern "C" int printf(const char *, ...);
 
@@ -11,4 +11,4 @@
 // CHECK: Running f()
 // CHECK-NEXT: Simple exception
 
-%quit
\ No newline at end of file
+%quit


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141380.487767.patch
Type: text/x-patch
Size: 691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230110/6ff6dc61/attachment.bin>


More information about the cfe-commits mailing list