[PATCH] D141050: [standalone-build] outsource, simplify and unify repetitive CMake code
Konrad Wilhelm Kleine via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 10 04:37:07 PST 2023
kwk updated this revision to Diff 487750.
kwk marked 2 inline comments as done.
kwk added a comment.
- Don't quote output variables
- Use 2 space indention in CMake files
- Make out_var optional for get_llvm_utility_binary_path
- Rename get_llvm_utility_binary_path -> require_llvm_utility_binary_path
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141050/new/
https://reviews.llvm.org/D141050
Files:
clang/CMakeLists.txt
cmake/Modules/StandaloneBuildHelpers.cmake
lld/CMakeLists.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141050.487750.patch
Type: text/x-patch
Size: 14793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230110/4403f9a3/attachment.bin>
More information about the cfe-commits
mailing list