[PATCH] D141349: Remove the ThreadLocal template from LLVM.
Nikita Popov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 10 01:33:41 PST 2023
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.
LGTM
> As a precaution, use LLVM_THREAD_LOCAL which provides even greater
> backwards compatibility, allowing this to function even pre-C++11
> versions of GCC.
I don't think backwards compatibility is still relevant given our minimum version requirements. We can probably drop the `__thread` fallback. What LLVM_THREAD_LOCAL does though is fall back to a normal variable if `!LLVM_ENABLE_THREADS`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141349/new/
https://reviews.llvm.org/D141349
More information about the cfe-commits
mailing list