[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 9 10:25:16 PST 2023
jansvoboda11 added inline comments.
================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:775
+ static llvm::StringMap<llvm::raw_fd_ostream> OSs;
+ std::unique_lock<std::mutex> LockGuard(Lock);
+
----------------
How will this work when a different process tries to write the same file? Could we write into a temporary file and then do atomic rename?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139168/new/
https://reviews.llvm.org/D139168
More information about the cfe-commits
mailing list