[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 9 08:54:14 PST 2023


cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:125
+                    diag::err_param_default_argument_references_local)
+             << D->getDeclName() << DefaultArg->getSourceRange();
   }
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > `ValueDecl` is a subclass of `NamedDecl` and the diagnostic printer knows how to properly print those -- I assume this is an NFC change (or near enough to it).
> Did this one not work the way I expected?
I'm still running the tests, It does seem fine :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137244/new/

https://reviews.llvm.org/D137244



More information about the cfe-commits mailing list