[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result
Vincent Hong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 9 03:16:31 PST 2023
v1nh1shungry added a comment.
> For the second test, the type is the internal type of std::vector.
There are two approaches to fixing this issue. One is fixing with the **FULLY** qualified type name, in the above case that is, `std::vector<int, std::allocator<int>>::size_type`. Another one is fixing with the desugared type name, that is, `unsigned long`. I personally don't have a strong opinion on which one is better.
WDYT, @bansan?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141058/new/
https://reviews.llvm.org/D141058
More information about the cfe-commits
mailing list