[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Sun Jan 8 23:07:49 PST 2023

carlosgalvezp added a comment.

In D141000#4034307 <https://reviews.llvm.org/D141000#4034307>, @carlosgalvezp wrote:

> Since we are at it - are we happy with the name "ImplementationFileExtensions"? I think "SourceFileExtensions" is more common in the literature, and it would look more visually pleasing in the config file since it has the same length as "HeaderFileExtensions".
>
>   HeaderFileExtensions: ["h", "hh"]
>   ImplementationFileExtensions: ["c", "cc"]
>
> vs
>
>   HeaderFileExtensions: ["h", "hh"]
>   SourceFileExtensions: ["c", "cc"]

Yes, there's a clear preference in the repo:

  $ git grep -E [sS]ource.?[fF]ile | wc -l
  5932
  $ git grep -E [iI]mplementation.?[fF]ile | wc -l
  104

Will change accordingly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141000/new/

https://reviews.llvm.org/D141000