[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

Fri Jan 6 17:59:04 PST 2023

owenpan added a comment.

In D141098#4030426 <https://reviews.llvm.org/D141098#4030426>, @rymiel wrote:

> The LLVM Coding Standard apparently doesn't mention line endings..?

Line endings probably should never be specified in coding standards, but the default should match the majority, and in the case of LLVM style, it should be `\n` IMO.

> A quick grep does show a bunch of \r\n results, primarily in tests.

It's possible that some/most of those `\r\n` get in by accident like in https://github.com/llvm/llvm-project/blob/617277e7cbdaea6881425c7a1a5b1cf4b1d4b507/clang/unittests/Format/FormatTest.cpp? And for tests, clang-format can be disabled like in D128706 <https://reviews.llvm.org/D128706>.

I think we should combine `DeriveLineEnding` and `UseCRLF`, with the default being LF for LLVM. If you all agree, I will abandon this patch and implement a new option and deprecate the current ones.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141098/new/

https://reviews.llvm.org/D141098