[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 10:48:24 PST 2023


cjdb added a comment.

LGTM, thanks for fixing!

Please be sure to have your commit message have `Fixes #59517` instead of a link to the issue, as this will close the bug upon merging.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/standalone-empty.cpp:586-590
+  {
+    std::vector<int> v;
+    return std::empty(v);
+    // no-warning
+  }
----------------
Please add additional cases similar to what's above (e.g. a case with `absl::empty`, an ADL-invoked case, etc.).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141107/new/

https://reviews.llvm.org/D141107



More information about the cfe-commits mailing list