[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

[Kelvin Li via Phabricator via cfe-commits]

kkwli0 added a comment.

In D140795#4022493 <https://reviews.llvm.org/D140795#4022493>, @awarzynski wrote:

> Hi @madanial , thanks for posting this!
>
>> This patch adds user option -funderscoring/-fnounderscoring which behaves similar to the gfortran option be enabling/disabling the ExternalNameConversionPass
>
> I don't quite understand what this option is for and it's hard to deduce from the patch. Please, could you add a link to some documentation? And tests.
>
> -Andrzej

@awarzynski  Thanks for the review. @madanial will not be available for the next few weeks. I will try to address some review comments while he is away.

The purpose of this option is to control the trailing underscore being appended to external names (e.g. procedure names, common block names). The option in gfortran is documented in https://gcc.gnu.org/onlinedocs/gfortran/Code-Gen-Options.html.

However, I don't think the patch does what we want. Given a procedure name `foo`, the `-fno-underscoring` option will give `_QPfoo` instead of `foo`. We will look into it.

However, I don't think the patch does what we want. Given a procedure name `foo`, the `-fno-underscoring` option will give `_QPfoo` instead of `foo`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140795/new/

https://reviews.llvm.org/D140795