[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values
Takuya Shimizu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 6 03:51:30 PST 2023
hazohelet added a comment.
> So, so long as a string literal still does the suppression, it's probably fine.
I agree with you. I now also think that integer literals _should not_ do the warning suppression because programmers are sometimes unsure of the expansion result of predefined macros in the compiled environment.
I updated the differential. I am new to Phabricator and made some unnecessary operations. Sorry for bothering you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140860/new/
https://reviews.llvm.org/D140860
More information about the cfe-commits
mailing list