[PATCH] D139458: [clangd] Full support for #import insertions

[David Goldman via Phabricator via cfe-commits]

dgoldman marked an inline comment as done.
dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572
+      // case where a header file contains ObjC decls but no #imports.
+      Symbol::IncludeDirective Directive = preferredIncludeDirective(
+          Filename, Clang->getLangOpts(), MainFileIncludes, {});
----------------
kadircet wrote:
> as discussed offline can you guard this with the `import-insertion` flag as well? we should pass it through ParseOptions.
Done, LMK if I did that properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139458/new/

https://reviews.llvm.org/D139458