[PATCH] D141035: [clang-format] Add an option to insert a newline at EOF if missing
Owen Pan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 5 15:07:32 PST 2023
owenpan added a comment.
In D141035#4028134 <https://reviews.llvm.org/D141035#4028134>, @MyDeveloperDay wrote:
> I think I've died an gone to heaven!! LGTM... Happy New Year!
Happy New Year to you too! Thanks to your comment in D19031#1747112 <https://reviews.llvm.org/D19031#1747112>, I remembered that I had fixed <https://github.com/owenca/haiku-format/commit/8f0720332fe5b65143bc857c0bfff7f916c9856e> it even before reporting the bug <https://bugs.llvm.org/show_bug.cgi?id=38694> back in 2018!
================
Comment at: clang/unittests/Format/FormatTest.cpp:25125-25126
+TEST_F(FormatTest, InsertNewlineAtEOF) {
+ verifyFormat("int i;\n");
+ verifyFormat("int i;");
+
----------------
Will remove them before landing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141035/new/
https://reviews.llvm.org/D141035
More information about the cfe-commits
mailing list