[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4275
+            TC->getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
+                << (TC->getTriple().isNVPTX() ? "NVPTX" : "AMDGPU")
+                << llvm::toString(GPUsOrErr.takeError()) << "--offload-arch";
----------------
arsenm wrote:
> should explicitly handle the different triple cases, rather than assume ! NVPTX is AMDGPU
why not just take the canonical triple arch name 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141078/new/

https://reviews.llvm.org/D141078