[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

[Thomas Lively via Phabricator via cfe-commits]

tlively accepted this revision.
tlively added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/simd-shuffle.ll:1-2
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+simd128,+relaxed-simd | FileCheck %s
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+simd128,+relaxed-simd -fast-isel | FileCheck %s
+
----------------
penzn wrote:
> Do we need both isel options? I felt bad about removing a test, but we don't check anything specific to the first run line.
I think it's good to check with and without fast isel just as a sanity check that fast isel falls back to dag isel correctly, but that's also covered in other tests, so I don't feel strongly about keeping it in this file specifically. Either way is fine with me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140773/new/

https://reviews.llvm.org/D140773