[PATCH] D139458: [clangd] Full support for #import insertions

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet requested changes to this revision.
kadircet added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572
+      // case where a header file contains ObjC decls but no #imports.
+      Symbol::IncludeDirective Directive = preferredIncludeDirective(
+          Filename, Clang->getLangOpts(), MainFileIncludes, {});
----------------
as discussed offline can you guard this with the `import-insertion` flag as well? we should pass it through ParseOptions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139458/new/

https://reviews.llvm.org/D139458