[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Thu Jan 5 07:16:45 PST 2023

Joe_Nash accepted this revision.
Joe_Nash added a comment.
This revision is now accepted and ready to land.

In D138870#4020211 <https://reviews.llvm.org/D138870#4020211>, @arsenm wrote:

> In D138870#4020204 <https://reviews.llvm.org/D138870#4020204>, @Joe_Nash wrote:
>
>> The code looks fine, but as you say, the change visible in user code and could break something. Do you want to handle that somehow? Maybe wait for @b-sumner
>
> OpenMP assumes flat pointers all over, so if someone was relying on this behavior it wasn't doing anything useful. They had dead code

I can't verify the idea that users of the behavior had dead code, but assuming that's right LGTM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138870/new/

https://reviews.llvm.org/D138870