[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 5 03:21:06 PST 2023


HazardyKnusperkeks added a comment.

In D140835#4023132 <https://reviews.llvm.org/D140835#4023132>, @owenpan wrote:

> In D140835#4023080 <https://reviews.llvm.org/D140835#4023080>, @HazardyKnusperkeks wrote:
>
>> On second thought, shouldn't we test for removing the braces?
>
> Hmm. This patch including the added test case //is// for removing braces.

Then replace `test` with `check`.
I mean if we don't want to remove braces and the line than becomes to long, because we keep the brace. As far as I can see that could now happen right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140835/new/

https://reviews.llvm.org/D140835



More information about the cfe-commits mailing list