[PATCH] D139847: Also allow __is_unsigned to be used as an identifier

Stephan Bergmann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 23:34:41 PST 2023


sberg abandoned this revision.
sberg added a comment.

In D139847#4026966 <https://reviews.llvm.org/D139847#4026966>, @aaron.ballman wrote:

> Do you know if folks are hitting problems here in practice, or is this speculative?

It had hit me when building LibreOffice against libstdc++ 13 trunk, so I started writing this hack.  In parallel, libstdc++ 13 trunk got changed again to not use `__is_unsigned` as an identifier, so there should be no published releases of libstdc++ where this would be an issue.  (And I had finished writing this hack anyway, just in case it might be useful.  And then forgot about it...  But maybe its best to just abandon it now.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139847/new/

https://reviews.llvm.org/D139847



More information about the cfe-commits mailing list