[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

Bill Wendling via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 17:06:14 PST 2023


void added inline comments.


================
Comment at: clang/include/clang/AST/Designator.h:313-319
+  /// ClearExprs - Null out any expression references, which prevents
+  /// them from being 'delete'd later.
+  void ClearExprs(Sema &Actions) {}
+
+  /// FreeExprs - Release any unclaimed memory for the expressions in
+  /// this designator.
+  void FreeExprs(Sema &Actions) {}
----------------
rsmith wrote:
> AST classes shouldn't reference `Sema`. But these functions do nothing; can they be removed?
Looks like they're dead. Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140584/new/

https://reviews.llvm.org/D140584



More information about the cfe-commits mailing list