[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Wed Jan 4 14:55:03 PST 2023

jcranmer-intel added inline comments.

================
Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:40
+static llvm::Type *getSPIRVType(llvm::LLVMContext &Ctx, StringRef BaseType,
+                                StringRef OpenCLName, StringRef ReadSuffix) {
+  SmallVector<unsigned, 7> IntParams = {0, 0, 0, 0, 0, 0};
----------------
bader wrote:
> I believe this can be done at "compile time" (i.e. during the clang build, not clang run).
> Can we have a pre-computed map from an OpenCL built-in type to a SPIR-V type?
> Another option is compile-time evaluated function. This should be possible, right?
> 
> If I get it right, here we take a string representation of an OpenCL image type and process it at runtime, which seems to be unnecessary as we have pre-defined (by the spec) set of the types.
I can definitely switch the read suffix to use a compile-time enum, since there are only 3 cases (plus, it's a static assert). Making the openCL name to int param conversion be a compile-time constant might be doable with some tricks, but I'll have to think about it for a little bit. It's a little harder because we're taking a string to 6 array values.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141008/new/

https://reviews.llvm.org/D141008