[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 14:29:02 PST 2023


dblaikie added a comment.

> This behavior can lead to the lack of warnings for complicated constexpr expressions.

Are those bugs, though? If the parentheses wouldn't change the outcome, due to the RHS being constant, maybe these undiagnosed cases aren't reflective of source code bugs/coding mistakes the user needs to change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140860/new/

https://reviews.llvm.org/D140860



More information about the cfe-commits mailing list