[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 14:19:43 PST 2023


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:22
+    : ToolChain(D, Triple, Args) {
+  for (Arg *A : Args.filtered(options::OPT_pg)) {
+    auto ArgString = A->getAsString(Args);
----------------
francii wrote:
> @MaskRay we still need `-pg` to error-out on z/OS. Should the check for this be moved to `clang/lib/Driver/ToolChains/Clang.cpp` instead?
Sounds reasonable to move `-pg` diagnostic beside `-p`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137756/new/

https://reviews.llvm.org/D137756



More information about the cfe-commits mailing list