[PATCH] D140992: clang: Add __builtin_elementsize_fma

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 07:18:16 PST 2023


arsenm created this revision.
arsenm added reviewers: fhahn, junaire, bob80905, python3kgae, RKSimon, aaron.ballman, erichkeane, scanon.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.

I didn't understand why the other builtins have promotion logic,
or how it would apply for a ternary operation. Implicit conversions
are evil to begin with,  and even more so when the purpose is to get
an exact IR intrinsic. This checks all the arguments have the same type.


https://reviews.llvm.org/D140992

Files:
  clang/docs/LanguageExtensions.rst
  clang/include/clang/Basic/Builtins.def
  clang/include/clang/Sema/Sema.h
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/lib/Sema/SemaChecking.cpp
  clang/test/CodeGen/builtins-elementwise-math.c
  clang/test/Sema/builtins-elementwise-math.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140992.486282.patch
Type: text/x-patch
Size: 15329 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230104/4db924fc/attachment-0001.bin>


More information about the cfe-commits mailing list