[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:507-511
+  // FIXME: Use a return value from EvalFn instead of isDifferent.
+  // Some functions should not change state and not have any other
+  // (invalidation, including errno) effect.
+  // For example if 'feof' is used with unknown stream we know that errno does
+  // not change (and presumably no other state that is otherwise invalidated).
----------------
Okay, but how does `CheckerContext::isDifferent()` misbehave in that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137790/new/

https://reviews.llvm.org/D137790