[PATCH] D140950: [X86] Support -march=emeraldrapids

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:810
 - Support intrinsics of ``_mm(256)_reduce_(max|min)_ep[i|u]8/16``.
+- ``-march=emeraldrapids`` is now supported.
 
----------------
Can this be on the same link as the other CPUs above?


================
Comment at: llvm/docs/ReleaseNotes.rst:191
 * ``-mcpu=sierraforest``, ``-mcpu=graniterapids`` and ``-mcpu=grandridge`` are now supported.
+* ``-mcpu=emeraldrapids`` is now supported.
 
----------------
Incorporate in the line above?


================
Comment at: llvm/lib/TargetParser/Host.cpp:851
 
+    // Emeraldrapids:
+    case 0xcf:
----------------
Should Emeraldrapids be two words here?


================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:396
   { {"graniterapids"}, CK_Graniterapids, FEATURE_AVX512BF16, FeaturesGraniteRapids },
+  // Emeraldrapids microarchitecture based processors.
+  { {"emeraldrapids"}, CK_Emeraldrapids, FEATURE_AVX512BF16, FeaturesSapphireRapids },
----------------
Should Emeraldrapids be two words here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140950/new/

https://reviews.llvm.org/D140950