[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

[Paul Kirth via Phabricator via cfe-commits]

paulkirth added a comment.

@thegameg Maybe? It seems straightforward, but I'll need take a look. If it's easy(which I think it willbe), I'll try to update this patch, if it's more complex, I'll probably do a separate patch to add that feature.



================
Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:84
+    ORE = &getAnalysis<MachineOptimizationRemarkEmitterPass>().getORE();
+    if (!ORE)
+      return false;
----------------
thegameg wrote:
> I don't think this should ever be null.
Ah, good point. I always default to nullptr checks, but in this case that should be impossible. thanks for pointing that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488