[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

Francis Visoiu Mistrih via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 11:30:35 PST 2023


thegameg added a comment.

This is great! Any chance we can use `MachineFrameInfo::StackProtectorIdx` to annotate the slot that is reserved for the stack protector?



================
Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:84
+    ORE = &getAnalysis<MachineOptimizationRemarkEmitterPass>().getORE();
+    if (!ORE)
+      return false;
----------------
I don't think this should ever be null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488



More information about the cfe-commits mailing list