[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 09:23:57 PST 2023


hubert.reinterpretcast added a comment.

In D137756#4018666 <https://reviews.llvm.org/D137756#4018666>, @MaskRay wrote:

> Most targets reject `-p` now. It's unnecessary to have another z/OS specific diagnostic. So this patch can be abandoned.
>
>   % fclang -p a.cc
>   clang-16: error: unsupported option '-p' for target 'x86_64-unknown-linux-gnu'

@francii, if you can confirm:

1. that there is a test that covers that error for z/OS, and
2. any comments in the code associated with generating the error above do not misrepresent the rationale for why `-p` is unsupported on z/OS,

then I'm good with leaving it at that.

Otherwise, we should make this into an NFC patch that adds the test/adjusts the comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137756/new/

https://reviews.llvm.org/D137756



More information about the cfe-commits mailing list