[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:2560
       IsInLambda = true;
-    if (MD->isInstance())
+    if (MD->isImplicitObjectMemberFunction())
       HasThisQuals = true;
----------------
erichkeane wrote:
> cor3ntin wrote:
> > erichkeane wrote:
> > > This bit probably  needs to wait until microsoft decides what the mangling for these are (all of microsoft mangle)
> > I've been chatting with Cameron, microsoft has decided :)
> > I still have to hear back from the GCC/Itanium folks though
> Ah! Good!  See whatever you can get to make sure we match though!
> 
> As far as Itanium, did you try posting on the Itanium github?
I wrote the tests from the microsoft implementation https://compiler-explorer.com/z/4df8f3e1j 
The github issue is there https://github.com/itanium-cxx-abi/cxx-abi/issues/148 - I also mailed a few folks this morning


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140828/new/

https://reviews.llvm.org/D140828