[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 07:16:15 PST 2023


erichkeane added a comment.

I agree with Corentin here, I've got no idea what the RIGHT solution looks like here, but this looks to be at least an improvement.  1 nit, plus  need a release note.  Otherwise LGTM.



================
Comment at: clang/test/CodeGenCXX/cxx20-unevaluated-lambda-crash.cpp:4
+// CHECK-LABEL: define linkonce_odr void @"_ZN10Issue579601EIiEENS_1FILNS_3$_0EEEEv"()
+namespace Issue57960{
+template<auto>
----------------
Nit: need a space after the name and before the {.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140554/new/

https://reviews.llvm.org/D140554



More information about the cfe-commits mailing list