[PATCH] D140543: [clang-format] Add an option to format integer literal separators

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 31 12:45:07 PST 2022


HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82
+
+  llvm::SpecificBumpPtrAllocator<Token> Allocator;
+  auto Tok = new (Allocator.Allocate()) Token;
+  Lex->LexFromRawLexer(*Tok);
----------------
owenpan wrote:
> HazardyKnusperkeks wrote:
> > owenpan wrote:
> > > I should allocate memory for the `Token` object as shown but instead had `Token Tok;` before.
> > But why? What is different?
> Thanks for asking! It made me find the real cause.
No problem! ;)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140543/new/

https://reviews.llvm.org/D140543



More information about the cfe-commits mailing list