[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Joe Nash via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 30 06:13:01 PST 2022


Joe_Nash added a comment.

The code looks fine, but as you say, the change visible in user code and could break something. Do you want to handle that somehow? Maybe wait for @b-sumner



================
Comment at: clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp:17
 #pragma omp metadirective                     \
-    when(device = {isa("flat-address-space")} \
+    when(device = {isa("dpp")} \
          : parallel) default(single)
----------------
Was the "dpp" attribute chosen arbitrarily?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138870/new/

https://reviews.llvm.org/D138870



More information about the cfe-commits mailing list