[PATCH] D140543: [clang-format] Add an option to format integer literal separators

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 29 19:02:25 PST 2022


owenpan updated this revision to Diff 485658.
owenpan added a comment.

It turns out that the memory bug had nothing to do with whether to use the stack or heap memory for the `Token` object. The culprit was passing `getFormattingLangOpts(Style)` directly to the `Lexer` constructor. I suppose in the Release build the copying of the returned `LangOptions` object is optimized out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140543/new/

https://reviews.llvm.org/D140543

Files:
  clang/docs/ClangFormatStyleOptions.rst
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Format/Format.h
  clang/lib/Format/CMakeLists.txt
  clang/lib/Format/Format.cpp
  clang/lib/Format/IntegerLiteralSeparatorFixer.cpp
  clang/lib/Format/IntegerLiteralSeparatorFixer.h
  clang/unittests/Format/CMakeLists.txt
  clang/unittests/Format/IntegerLiteralSeparatorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140543.485658.patch
Type: text/x-patch
Size: 23244 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221230/818133a2/attachment-0001.bin>


More information about the cfe-commits mailing list