[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

Tue Dec 27 20:59:50 PST 2022

cpsauer added a subscriber: nridge.
cpsauer added a comment.

Ooh interesting. Thanks for your careful look, @ArcsinX.

To check my understanding: Sounds like, more generally, commands get massaged into clang argument form before they're passed into the query-driver machinery, which can break break calls through to other compilers.

So far that hadn't affected things, but probably we should be relayering things to operate on raw commands for query driver?
@nridge, I know you'd fixed a bunch of problems by relayering in the past. Any thoughts on this one?

More generally folks more experienced in the codebase: Any thoughts on how we should do this?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138546/new/

https://reviews.llvm.org/D138546