[PATCH] D140543: [clang-format] Add an option to format integer literal separators

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D140543#4016181 <https://reviews.llvm.org/D140543#4016181>, @owenpan wrote:

> In D140543#4016156 <https://reviews.llvm.org/D140543#4016156>, @thakis wrote:
>
>> This seems to break tests everywhere, eg http://45.33.8.238/linux/95289/step_7.txt
>>
>> Please take a look and revert for now if it takes a while to fix.
>
> I had run FormatTests on Windows and macOS without any problems and don't understand why the build bots failed. I will disable the `FixRanges` test as a workaround.

FWIW it also fails on Windows and macOS on my bots: http://45.33.8.238/macm1/51645/step_7.txt http://45.33.8.238/win/72399/step_7.txt

If the test is failing, why not revert the commit for now instead of disabling the test? That's what we usually do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140543/new/

https://reviews.llvm.org/D140543