[PATCH] D140543: [clang-format] Add an option to format integer literal separators

[Owen Pan via Phabricator via cfe-commits]

owenpan planned changes to this revision.
owenpan added a comment.

Will extend this option to support C#, Java, and JavaScript using the underscore character `_` as the separator.



================
Comment at: clang/unittests/Format/FormatTest.cpp:25124
 
+TEST_F(FormatTest, IntegerLiteralSeparator) {
+  FormatStyle Style = getLLVMStyle();
----------------
HazardyKnusperkeks wrote:
> I'd like to see `FormatTest.cpp` shrink, maybe add this in a new file?
If this test will grow to, say, 100+ lines, it’ll be worth the overhead. Meanwhile, we can move quit a few other much large tests out into their own files.


================
Comment at: clang/unittests/Format/FormatTest.cpp:25166
+               Style);
+}
+
----------------
HazardyKnusperkeks wrote:
> Add a test that we really don't touch floating points?
Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140543/new/

https://reviews.llvm.org/D140543