[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 22 17:33:55 PST 2022


benshi001 added a comment.

In D139305#4013217 <https://reviews.llvm.org/D139305#4013217>, @aykevl wrote:

> I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is inherently specific to that particular chip anyway so compatibility is not an issue. In fact, having two flags may even introduce noise and confusion.
> I wouldn't be opposed to it though if there is demand for it.
>
> In D139305#3987969 <https://reviews.llvm.org/D139305#3987969>, @MaskRay wrote:
>
>> Does GCC prefer `-mcpu=` as well? If not, raise a PR there? This seems like a decision we should not unilaterally make on llvm-project side: it's certainly something GCC cares about as well.
>
> I guess, but avr-gcc is already barely maintained. Most people use an older version (like 5.2.0) because the newer versions produce absolutely terrible code. So I don't think it matters much.

I see. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139305/new/

https://reviews.llvm.org/D139305



More information about the cfe-commits mailing list