[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

Thu Dec 22 15:04:19 PST 2022

MaskRay added a comment.

In D140224#4014243 <https://reviews.llvm.org/D140224#4014243>, @rsundahl wrote:

>> I'll reject [-\Xparser for a while as well. This is a valid amendment to D139717 <https://reviews.llvm.org/D139717> , so I don't think it needs more approval.
>
> We have projects that are failing because of -Xlinker and I'm not too excited about walking through every project we have to find more examples. Can we please have a reprieve on deprecating this until every project in the world that uses these flags that have existed for a very long time can have a chance to at least get timely notification? Why is this any different than anything else that gets deprecated?

Thank you for your reply! If there are more issues -Xlinker/-Xparser/-Xcctests, ok, I think I'm fine with a Joined -X, but ideally we can figure out a way to apply that only to Apple platforms.

(FWIW I feel sad when I made valid objection to D139717 <https://reviews.llvm.org/D139717>, but that patch landed very soon after your colleague approved it, leaving me no time to object.
My other objection included the insufficient commit message `-Xfoo` instead of what's actually used, `internal builds` which seems to hint an internal workaround, where the tests are located)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140224/new/

https://reviews.llvm.org/D140224