[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead
Davide Italiano via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 22 14:55:06 PST 2022
davide added a comment.
In D140224#4014230 <https://reviews.llvm.org/D140224#4014230>, @MaskRay wrote:
> In D140224#4014203 <https://reviews.llvm.org/D140224#4014203>, @davide wrote:
>
>> @MaskRay Roy hasn't replied. We found other spellings that break (e.g. `-Xcctests` or something). Revert this patch until we find an agreement.
>
> D139717 <https://reviews.llvm.org/D139717> (this patch reverts) was pushed when I made valid comments which were ignored. I did not complain for that.
>
> I don't mind if you work around `-Xcctests` in a similar way.
Working around 3 cases creates more complexity than it fixes.
We're also not providing a deprecation path for users. This needs to be discussed more thoroughly. I'll go ahead and revert to the previous status.
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140224/new/
https://reviews.llvm.org/D140224
More information about the cfe-commits
mailing list