[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 22 09:17:36 PST 2022


arsenm added inline comments.


================
Comment at: clang/test/CodeGen/builtins-x86-reduce.c:8
+}
+
+// CHECK: fadd
----------------
pengfei wrote:
> arsenm wrote:
> > Should test the builtins from both sets
> Do you mean this?
Almost. You added the guard to 4 switch cases, so I would expect at minimum one builtin from each of the cases. These are both the same builtin. You also should have an fmul, fmin and fmax case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140467/new/

https://reviews.llvm.org/D140467



More information about the cfe-commits mailing list