[PATCH] D140543: [clang-format] Add an option to format integer literal separators

[Owen Pan via Phabricator via cfe-commits]

owenpan marked an inline comment as done.
owenpan added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:2395
+  /// >0: Insert separators between digits, starting from the rightmost digit.
+  struct IntegerLiteralSeparatorStyle {
+    /// \code
----------------
HazardyKnusperkeks wrote:
> Also add Octal?
I don't know if anyone would want to group octal digits. I can add it in the future if it's really useful.


================
Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:20
+
+enum class Base { Binary, Decimal, Hex, Other };
+
----------------
HazardyKnusperkeks wrote:
> Other is Octal.
`Other` includes octal and other ill-formed integers (if any).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140543/new/

https://reviews.llvm.org/D140543