[PATCH] D140547: Perform access checking to private members in simple requirement.

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 22 07:56:02 PST 2022


shafik added a comment.

Thank you for the fix, can you elaborate on the motivation for this change, it looks like setting `setNamingClass` allows for improved diagnostics but I would like it explained better in the PR description.



================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2244
 TemplateInstantiator::TransformExprRequirement(concepts::ExprRequirement *Req) {
-  if (!Req->isDependent() && !AlwaysRebuild())
-    return Req;
----------------
Why this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140547/new/

https://reviews.llvm.org/D140547



More information about the cfe-commits mailing list