[PATCH] D140543: [clang-format] Add an option to format integer literal separators

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:2395
+  /// >0: Insert separators between digits, starting from the rightmost digit.
+  struct IntegerLiteralSeparatorStyle {
+    /// \code
----------------
Also add Octal?


================
Comment at: clang/include/clang/Format/Format.h:4121
            IndentWrappedFunctionNames == R.IndentWrappedFunctionNames &&
+           IntegerLiteralSeparator.Binary == R.IntegerLiteralSeparator.Binary &&
+           IntegerLiteralSeparator.Decimal ==
----------------
Below Insert, same above.


================
Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:20
+
+enum class Base { Binary, Decimal, Hex, Other };
+
----------------
Other is Octal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140543/new/

https://reviews.llvm.org/D140543